On 06/19/2013 03:10 PM, Andrew Morton wrote: > On Wed, 19 Jun 2013 14:55:13 +0800 Chen Gang <gang.chen@xxxxxxxxxxx> wrote: > >> > >> > 'lru' may be used without initialized, so need regressing part of the >> > related patch. >> > >> > The related patch: >> > "3abf380 mm: remove lru parameter from __lru_cache_add and lru_cache_add_lru" >> > >> > ... >> > >> > --- a/mm/vmscan.c >> > +++ b/mm/vmscan.c >> > @@ -595,6 +595,7 @@ redo: >> > * unevictable page on [in]active list. >> > * We know how to handle that. >> > */ >> > + lru = !!TestClearPageActive(page) + page_lru_base_type(page); >> > lru_cache_add(page); >> > } else { >> > /* > That looks right. Why the heck didn't gcc-4.4.4 (at least) warn about it? > Sorry I don't know either, I find it by reading code, this time. It is really necessary to continue analyzing why. In 2nd half of 2013, I have planned to make some patches outside kernel but related with kernel (e.g. LTP, gcc patches). This kind of issue is a good chance for me to start in 2nd half of 2013 (start from next month). So if no others reply for it, I will start analyzing it in the next month, and plan to finish within a month (before 2013-07-31). Welcome additional suggestions or completions. Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>