On 06/14/2013 05:31 PM, Michal Hocko wrote: > On Fri 14-06-13 12:29:52, Kirill A. Shutemov wrote: >> Michal Hocko wrote: >>> On Fri 14-06-13 15:30:34, Wanpeng Li wrote: >>>> There is just one caller in fs-writeback.c call wb_do_writeback and >>>> current codes unnecessary export it in header file, this patch fix >>>> it by changing wb_do_writeback to static function. >>> >>> So what? >>> >>> Besides that git grep wb_do_writeback tells that >>> mm/backing-dev.c: wb_do_writeback(me, 0); >>> >>> Have you tested this at all? >> >> Commit 839a8e8 removes that. > > OK, I didn't check the most up-to-date tree. Sorry about this confusion. > I do not object to cleanups like this but it should be clear they are > cleanups. "fix wb_do_writeback exported unsafely" sounds like a fix > rather than a cleanup Agreed. > >>>> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> >> >> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> >> >> -- >> Kirill A. Shutemov >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@xxxxxxxxx. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>