Re: [PATCH] mm/page_alloc: don't re-init pageset in zone_pcp_update()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/12/2013 02:20 PM, Andrew Morton wrote:
On Tue, 11 Jun 2013 15:12:59 -0700 Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx> wrote:

Factor pageset_set_high_and_batch() (which contains all needed logic too
set a pageset's ->high and ->batch inrespective of system state) out of
zone_pageset_init(), which avoids us calling pageset_init(), and
unsafely blowing away a pageset at runtime (leaked pages and
potentially some funky allocations would be the result) when memory
hotplug is triggered.

This changelog is pretty screwed up :( It tells us what the patch does
but not why it does it.


It says why it does it, though perhaps a bit hidden:
>  avoids us calling pageset_init(), and unsafely blowing away a pageset

Signed-off-by: Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx>
---

Unless memory hotplug is being triggered on boot, this should *not* be cause of Valdis
Kletnieks' reported bug in -next:
          "next-20130607 BUG: Bad page state in process systemd pfn:127643"

And this addendum appears to hint at the info we need.

Note the *not*. I included this note only because I expected there would be a question of whether Valdis's reported bug was caused by this. It _isn't_. The bug this fix fixes is only triggered by memory_hotplug, and Valdis's bug occurred on boot.

Please, send a new changelog?  That should include a description of the
user-visible effects of the bug which is being fixed,  a description of
why it occurs and a description of how it was fixed.It would also be
helpful if you can identify which kernel version(s) need the fix.

It's just a -mm issue. It was introduced by my patchset starting with "mm/page_alloc: factor out setting of pcp->high and pcp->batch", where the actual place the bug snuck in was "mm/page_alloc: in zone_pcp_update(), uze zone_pageset_init()".


Also, a Reported-by:Valdis would be appropriate.

I'm fine with adding it (I did take a look at my page_alloc.c changes because he reported that bug), but as mentioned before, this fixes a different bug.

Anyhow, a reorganized (and clearer) changelog with the same content follows:
---
mm/page_alloc: don't re-init pageset in zone_pcp_update()

When memory hotplug is triggered, we call pageset_init() on a per-cpu-pageset which both contains pages and is in use, causing both the leakage of those pages and (potentially) bad behaviour if a page is allocated from the pageset while it is being cleared.

Avoid this by factoring pageset_set_high_and_batch() (which contains all needed logic too set a pageset's ->high and ->batch inrespective of system state), and using that instead of zone_pageset_init() in zone_pcp_update().

Signed-off-by: Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx>



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]