On Mon, 10 Jun 2013, Nicolas Palix wrote: > On Mon, Jun 10, 2013 at 5:18 PM, Christoph Lameter <cl@xxxxxxxxxx> wrote: > > On Mon, 10 Jun 2013, Nicolas Palix wrote: > > > >> I notice that in the SLAB allocator, local_irq_save and > >> local_irq_restore are called in slab_alloc_node and slab_alloc without > >> checking the GFP_WAIT bit of the flags parameter. > > > > SLAB does the same as SLUB. Have a look at mm/slab.c:cache_grow() > > I agree and it is the same for mm/slab.c:fallback_alloc() but > why is it not also required for mm/slab.c:slab_alloc_node() > and mm/slab.c:slab_alloc() which both manipulate the local irqs? Because cache_grow calls into the page allocator and we cannot do reclaim with interrupts off. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>