Re: [PATCH v10 04/35] dentry: move to per-sb LRU locks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/06/2013 03:07 AM, Andrew Morton wrote:
> On Mon,  3 Jun 2013 23:29:33 +0400 Glauber Costa <glommer@xxxxxxxxxx> wrote:
> 
>> From: Dave Chinner <dchinner@xxxxxxxxxx>
>>
>> With the dentry LRUs being per-sb structures, there is no real need
>> for a global dentry_lru_lock. The locking can be made more
>> fine-grained by moving to a per-sb LRU lock, isolating the LRU
>> operations of different filesytsems completely from each other.
> 
> What's the point to this patch?  Is it to enable some additional
> development, or is it a standalone performance tweak?
> 
> If the latter then the patch obviously makes this dentry code bloatier
> and straight-line slower.  So we're assuming that the multiprocessor
> contention-avoidance benefits will outweigh that cost.  Got any proof
> of this?
> 
> 
This is preparation for the whole point of this series, which is to
abstract the lru manipulation into a list_lru. It is hard to do that
when the dcache has a single lock for all manipulations, and multiple
lists under its umbrella.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]