Re: [PATCH 1/7] mm: remove ZONE_RECLAIM_LOCKED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(6/5/13 4:51 PM), Christoph Lameter wrote:
On Wed, 5 Jun 2013, KOSAKI Motohiro wrote:

(6/5/13 11:10 AM), Andrea Arcangeli wrote:
Zone reclaim locked breaks zone_reclaim_mode=1. If more than one
thread allocates memory at the same time, it forces a premature
allocation into remote NUMA nodes even when there's plenty of clean
cache to reclaim in the local nodes.

Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>

You should Christoph Lameter who make this lock. I've CCed. I couldn't
find any problem in this removing. But I also didn't find a reason why
this lock is needed.

There was early on an issue with multiple zone reclaims from
different processors causing an extreme slowdown and the system would go
OOM. The flag was used to enforce that only a single zone reclaim pass was
occurring at one time on a zone. This minimized contention and avoided
the failure.

OK. I've convinced now we can removed because sc->nr_to_reclaim protect us form
this issue.

Thank you, guys.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]