On Wed 05-06-13 10:39:49, Johannes Weiner wrote: [...] > You hate the barriers, so let's add a lock to access the iterator. > That path is not too hot in most cases. yes, basically only reclaimers use that path which makes it a slow path by definition. > On the other hand, the weak pointer is not too esoteric of a pattern > and we can neatly abstract it into two functions: one that takes an > iterator and returns a verified css reference or NULL, and one to > invalidate pointers when called from the memcg destruction code. would be nice. > These two things should greatly simplify mem_cgroup_iter() while not > completely abandoning all our optimizations. > > What do you think? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>