On Wed 29-05-13 12:53:56, Andrew Morton wrote: > On Mon, 27 May 2013 14:02:58 +0100 Mel Gorman <mgorman@xxxxxxx> wrote: > > > Page reclaim keeps track of dirty and under writeback pages and uses it to > > determine if wait_iff_congested() should stall or if kswapd should begin > > writing back pages. This fails to account for buffer pages that can be under > > writeback but not PageWriteback which is the case for filesystems like ext3 > > ordered mode. Furthermore, PageDirty buffer pages can have all the buffers > > clean and writepage does no IO so it should not be accounted as congested. > > iirc, the PageDirty-all-buffers-clean state is pretty rare. It might > not be worth bothering about? Not true for ext3 in data=ordered mode. In some workloads, kjournald ends up writing most of the data during journal commit and that exactly leaves dirty pages with clean buffers. So in such setup lots of dirty pages can be of that strange kind... Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>