Re: [PATCH v8 16/34] xfs: convert buftarg LRU to generic code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 24, 2013 at 03:59:10PM +0530, Glauber Costa wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Convert the buftarg LRU to use the new generic LRU list and take
> advantage of the functionality it supplies to make the buffer cache
> shrinker node aware.
> 
> * v7: Add NUMA aware flag

I know what is wrong with this patch that causes the unmount hang -
it's the handling of the _XBF_LRU_DISPOSE flag no longer being
modified atomically with the LRU lock. Hence there is a race where
we can either lose the _XBF_LRU_DISPOSE or not see it and hence we
can end up with code not detecting what list the buffer is on
correctly.

I haven't had a chance to work out a fix for it yet. If this ends up
likely to hold up the patch set, Glauber, then feel free to drop it
from the series and I'll push a fixed version through the XFS tree
in due course....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]