Re: [PATCHv4 33/39] thp, mm: implement do_huge_linear_fault()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hillf Danton wrote:
> On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov
> <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:
> > @@ -3316,17 +3361,25 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> >                 if (unlikely(anon_vma_prepare(vma)))
> >                         return VM_FAULT_OOM;
> >
> > -               cow_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, address);
> > +               cow_page = alloc_fault_page_vma(vma, address, flags);
> >                 if (!cow_page)
> > -                       return VM_FAULT_OOM;
> > +                       return VM_FAULT_OOM | VM_FAULT_FALLBACK;
> >
> 
> Fallback makes sense with !thp ?

No, it's nop. handle_pte_fault() will notice only VM_FAULT_OOM. That's
what we need.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]