On 05/22/2013 07:22 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >>> + /* >>> + * TODO: make ramfs pages movable >>> + */ >>> + mapping_set_gfp_mask(inode->i_mapping, >>> + GFP_TRANSHUGE & ~__GFP_MOVABLE); >> >> So, before these patches, ramfs was movable. Now, even on architectures >> or configurations that have no chance of using THP-pagecache, ramfs >> pages are no longer movable. Right? > > No, it wasn't movable. GFP_HIGHUSER is not GFP_HIGHUSER_MOVABLE (yeah, > names of gfp constants could be more consistent). > > ramfs should be fixed to use movable pages, but it's outside the scope of the > patchset. > > See more details: http://lkml.org/lkml/2013/4/2/720 Please make sure this is clear from the patch description. Personally, I wouldn't be adding TODO's to the code that I'm not planning to go fix, lest I would get tagged with _doing_ it. :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>