Dave Hansen wrote: > On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > > From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> > > > > It's confusing that mk_huge_pmd() has sematics different from mk_pte() > > or mk_pmd(). > > > > Let's move maybe_pmd_mkwrite() out of mk_huge_pmd() and adjust > > prototype to match mk_pte(). > > Was there a motivation to do this beyond adding consistency? Do you use > this later or something? I spent some time on debugging problem caused by this inconsistency, so at that point I was motivated to fix it. :) -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>