On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> > > Let's cleanup __do_fault() to prepare it for transparent huge pages > support injection. > > Cleanups: > - int -> bool where appropriate; > - unindent some code by reverting 'if' condition; > - extract !pte_same() path to get it clear; > - separate pte update from mm stats update; > - some comments reformated; I've scanned through the rest of these patches. They look OK, and I don't have _too_ much to say. They definitely need some closer review, but I think you should concentrate your attention on the stuff _before_ this point in the series. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>