On Mon, May 20, 2013 at 08:39:08PM +0400, Glauber Costa wrote:
> On 05/20/2013 12:07 AM, Glauber Costa wrote:
> > +static long super_cache_count(struct shrinker *shrink, struct shrink_control *sc)
> > +{
> > + struct super_block *sb;
> > + long total_objects = 0;
> > +
> > + sb = container_of(shrink, struct super_block, s_shrink);
> > +
> > + if (!grab_super_passive(sb))
> > + return -1;
>
> Dave,
>
> This is wrong, since mm/vmscan.c will WARN on count returning -1.
> Only scan can return -1, and this is probably a mistake while moving
> code over. Unless you shout, I am fixing this to "return 0" in this case.
That's why the WARN_ON() was put in shrink slab - to catch stuff
like this. ;)
So yes, it should return 0 here.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>