On Tue 14-05-13 18:49:07, Glauber Costa wrote: > On 05/14/2013 06:44 PM, Michal Hocko wrote: > > On Tue 14-05-13 16:40:31, Michal Hocko wrote: > >> On Tue 14-05-13 16:38:38, Andrey Vagin wrote: > >>> struct memcg_cache_params has a union. Different parts of this union are > >>> used for root and non-root caches. A part with destroying work is used only > >>> for non-root caches. > >> > >> but memcg_update_cache_size is called only for !root caches AFAICS > >> (check memcg_update_all_caches) > > > > Ohh, I am blind. memcg_update_all_caches skips all !root caches. > > Then the patch looks correct. If Glauber has nothing against then thise > > should be marked for stable (3.9) > > > This was recently introduced by the commit that moved the initialization > earlier (15cf17d26e08ee9). It basically moved too much, and I didn't > catch it. If that patch is in 3.9, then yes, this needs to go to stable. > Otherwise it is not affected. git describe tells it was merged in v3.9-rc2~7 > However, I do remember Andrey telling me that he hit this bug in both > 3.9 and 3.10-rc1, so yes, stable it is. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>