On Wed, 1 May 2013, Cody P Schafer wrote: > > > Signed-off-by: Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx> > > > > Nack, pgdat_resize_unlock() is unnecessary if irqs are known to be > > disabled. > > > > All this patch does is is indicate that rather than using node_size_lock > directly (as it won't be around without CONFIG_MEMORY_HOTPLUG), one should use > the pgdat_resize_[un]lock() helper macros. > I think that's obvious given the lock is surrounded by #ifdef CONFIG_MEMORY_HOTPLUG. The fact remains that hotplug code need not use pgdat_resize_lock() if irqs are disabled. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>