On Sat, Apr 27, 2013 at 03:19:03AM +0400, Glauber Costa wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Convert superblock shrinker to use the new count/scan API, and > propagate the API changes through to the filesystem callouts. The > filesystem callouts already use a count/scan API, so it's just > changing counters to longs to match the VM API. > > This requires the dentry and inode shrinker callouts to be converted > to the count/scan API. This is mainly a mechanical change. > > [ glommer: use mult_frac for fractional proportions, build fixes ] > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Signed-off-by: Glauber Costa <glommer@xxxxxxxxxx> It's slightly clearer on seeing this patch why you went with long instead of unsigned long in the previous patch. It matched closer to what the shrinkers were already doing with their counters and of course they already understood -1 but as the API is being churned anyway, it would not hurt to use unsigned long for counters and ULONG_MAX for errors. I spotted no specific problem with this patch itself and there is some nice tidy-ups in there. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>