On 04/18/2013 09:38 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >> On 04/18/2013 09:09 AM, Kirill A. Shutemov wrote: >>> Dave Hansen wrote: >>>> On 04/17/2013 07:38 AM, Kirill A. Shutemov wrote: >>>> Are you still sure you can't do _any_ better than a verbatim copy of 129 >>>> lines? >>> >>> It seems I was too lazy. Shame on me. :( >>> Here's consolidated version. Only build tested. Does it look better? >> >> Yeah, it's definitely a step in the right direction. There rae >> definitely some bugs in there like: >> >> + unsigned long haddr = address & PAGE_MASK; > > It's not bug. It's bad name for the variable. > See, first 'if (try_huge_pages)'. I update it there for huge page case. > > addr_aligned better? That's a criminally bad name. :) addr_aligned is better, and also please initialize the two cases together. It's mean to separate them. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>