Re: Return value of __mm_populate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adding in cc: lkml

Il 13/04/2013 14:14, Marco Stornelli ha scritto:
Hi,

I was seeing the code of __mm_populate (in -next) and I've got a doubt
about the return value. The function __mlock_posix_error_return should
return a proper error for mlock, converting the return value from
__get_user_pages. It checks for EFAULT and ENOMEM. Actually
__get_user_pages could return, in addition, ERESTARTSYS and EHWPOISON.
So it seems to me that we could return to user space not expected value.
I can't see them on the man page. In addition we shouldn't ever return
ERESTARTSYS to the user space but EINTR. According to the man pages
maybe we should return EAGAIN in these cases. Am I missing something?

Thanks,

Marco

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]