On Wed, Apr 10, 2013 at 08:25:55AM +0800, Wanpeng Li wrote: > Note that at this point there is no CONFIG_RAMSTER_DEBUG > option in the Kconfig. So in effect all of the counters > are nop until that option gets re-introduced in: > zcache/ramster/debug: Add RAMSTE_DEBUG Kconfig entry This patch breaks the build badly: drivers/staging/zcache/ramster/ramster.c: In function ‘ramster_localify’: drivers/staging/zcache/ramster/ramster.c:159:4: error: ‘ramster_remote_eph_pages_unsucc_get’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:159:4: note: each undeclared identifier is reported only once for each function it appears in drivers/staging/zcache/ramster/ramster.c:161:4: error: ‘ramster_remote_pers_pages_unsucc_get’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:212:3: error: ‘ramster_remote_eph_pages_succ_get’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:214:3: error: ‘ramster_remote_pers_pages_succ_get’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c: In function ‘ramster_pampd_repatriate_preload’: drivers/staging/zcache/ramster/ramster.c:299:3: error: ‘ramster_pers_pages_remote_nomem’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c: In function ‘ramster_remote_flush_page’: drivers/staging/zcache/ramster/ramster.c:437:3: error: ‘ramster_remote_pages_flushed’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:439:3: error: ‘ramster_remote_page_flushes_failed’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c: In function ‘ramster_remote_flush_object’: drivers/staging/zcache/ramster/ramster.c:454:3: error: ‘ramster_remote_objects_flushed’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:456:3: error: ‘ramster_remote_object_flushes_failed’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c: In function ‘ramster_remotify_pageframe’: drivers/staging/zcache/ramster/ramster.c:507:5: error: ‘ramster_eph_pages_remote_failed’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:509:5: error: ‘ramster_pers_pages_remote_failed’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:516:4: error: ‘ramster_eph_pages_remoted’ undeclared (first use in this function) drivers/staging/zcache/ramster/ramster.c:518:4: error: ‘ramster_pers_pages_remoted’ undeclared (first use in this function) make[3]: *** [drivers/staging/zcache/ramster/ramster.o] Error 1 Please always test your patches. I've applied patch 1, 3, and 4 in this series. Please fix this up if you want me to apply anything else. greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>