On Mon, 8 Apr 2013, Toshi Kani wrote: > > So we don't need this new code if CONFIG_MEMORY_HOTPLUG=n? If so, can > > we please arrange for it to not be present if the user doesn't need it? > > Good point! Yes, since the new function is intended for memory > hot-delete and is only called from __remove_pages() in > mm/memory_hotplug.c, it should be added as #ifdef CONFIG_MEMORY_HOTPLUG > in PATCH 2/3. > > I will make the change, and send an updated patch to PATCH 2/3. > It should actually depend on CONFIG_MEMORY_HOTREMOVE, but the pseries OF_RECONFIG_DETACH_NODE code seems to be the only code that doesn't make that distinction. CONFIG_MEMORY_HOTREMOVE acts as a wrapper to protect configs that don't have ARCH_ENABLE_MEMORY_HOTREMOVE, so we'll want to keep it around and presumably that powerpc code depends on it as well. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>