On Sun, Apr 07, 2013 at 10:51:27AM -0700, Dan Magenheimer wrote: >> From: Wanpeng Li [mailto:liwanp@xxxxxxxxxxxxxxxxxx] >> Subject: Re: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently >> >> Hi Dan, >> >> Some issues against Ramster: >> >> - Ramster who takes advantage of zcache also should support zero-filled >> pages more efficiently, correct? It doesn't handle zero-filled pages well >> currently. > >When you first posted your patchset I took a quick look at ramster >and it looked like your patchset should work for ramster also. >However I didn't actually run ramster to try it so there may >be a bug. If it doesn't work, I would very much appreciate a patch. > >> - Ramster DebugFS counters are exported in /sys/kernel/mm/, but zcache/frontswap/cleancache >> all are exported in /sys/kernel/debug/, should we unify them? > >That would be great. > >> - If ramster also should move DebugFS counters to a single file like >> zcache do? > >Sure! I am concerned about Konrad's patches adding debug.c as they >add many global variables. They are only required when ZCACHE_DEBUG >is enabled so they may be ok. If not, adding ramster variables >to debug.c may make the problem worse. > >> If you confirm these issues are make sense to fix, I will start coding. ;-) Hi Dan, > >That would be great. Note that I have a how-to for ramster here: > >https://oss.oracle.com/projects/tmem/dist/files/RAMster/HOWTO-120817 > >If when you are testing you find that this how-to has mistakes, >please let me know. Or feel free to add the (corrected) how-to file >as a patch in your patchset. You can review my patchset [PATCH 00/10] staging: zcache/ramster: fix and ramster/debugfs improvement Just update TESTING RAMSTER part since some knobs are eported in /sys/kernel/debug/ramster/ instead of /sys/kernel/mm/ramster/ for your HOWTO file. D. TESTING RAMSTER +2) To see if RAMster is working, on the remote system Regards, Wanpeng Li > >Thanks very much, Wanpeng, for your great contributions! > >(Ric, since you have expressed interest in ramster, if you try it and >find corrections to the how-to file above, your input would be >very much appreciated also!) > >Dan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>