For all the do_huge_pmd_wp_page(), I think we need a better description
of where the code came from. There are some more obviously
copy-n-pasted comments in there.
For the entire series, in the patch description, we need to know:
1. What was originally written and what was copied from elsewhere
2. For the stuff that was copied, was an attempt made to consolidate
instead of copy? Why was consolidation impossible or infeasible?
> + if (!PageAnon(page)) {
> + add_mm_counter(mm, MM_FILEPAGES, -HPAGE_PMD_NR);
> + add_mm_counter(mm, MM_ANONPAGES, HPAGE_PMD_NR);
> + }
This seems like a bit of a hack. Shouldn't we have just been accounting
to MM_FILEPAGES in the first place?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>