On Sun, Apr 07, 2013 at 10:59:18AM -0700, Dan Magenheimer wrote: >> From: Dan Magenheimer >> Subject: RE: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently >> >> > From: Wanpeng Li [mailto:liwanp@xxxxxxxxxxxxxxxxxx] >> > Subject: Re: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently >> > >> > Hi Dan, >> > >> > Some issues against Ramster: >> > >> >> Sure! I am concerned about Konrad's patches adding debug.c as they >> add many global variables. They are only required when ZCACHE_DEBUG >> is enabled so they may be ok. If not, adding ramster variables >> to debug.c may make the problem worse. > >Oops, I just noticed/remembered that ramster uses BOTH debugfs and sysfs. >The sysfs variables are all currently required, i.e. for configuration >so should not be tied to debugfs or a DEBUG config option. However, >if there is a more acceptable way to implement the function of >those sysfs variables, that would be fine. So if we need move debugfs counters to a single debug.c in zcache/ramster/ and introduce RAMSTER_DEBUG? The work similiar as Konrad done against zcache. ;-) Regards, Wanpeng Li > >Thanks, >Dan > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@xxxxxxxxx. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>