On 04/03/2013 10:51 AM, Sha Zhengju wrote: > +static void > +shrink_dcache_list( > + struct list_head *dispose) > +{ > + struct dentry *dentry; > + > + rcu_read_lock(); > + list_for_each_entry_rcu(dentry, dispose, d_lru) { > + spin_lock(&dentry->d_lock); > + dentry->d_flags |= DCACHE_SHRINK_LIST; > + this_cpu_dec(nr_dentry_unused); > > > Why here dec nr_dentry_unused again? Has it been decreased in the > following shrink_dcache_sb()? You analysis seems to be correct, and the decrement in shrink_dcache_sb seems not to be needed. Dave, have comments on this ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>