On Mon, Apr 1, 2013 at 10:46 PM, Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> wrote:
> commit 9c0ad59ef ("zcache/debug: Use an array to initialize/use debugfs attributes")
> use an array to initialize/use debugfs attributes, .name = #x, .val = &zcache_##x.
> For zcache writeback, this commit set .name = zcache_outstanding_writeback_pages and
> .name = zcache_writtenback_pages seperately, however, corresponding .val =
> &zcache_zcache_outstanding_writeback_pages and .val = &zcache_zcache_writtenback_pages,
> which are not correct.
>
Weird. I recall spotting that when I did the patches, but I wonder how
I missed this.
Ah, now I remember - I did a silly patch by adding in #define
CONFIG_ZCACHE_WRITEBACK
in the zcache-main.c code, but forgot to try it out here.
<sigh>
Thank you for spotting and fixing it.
Reviewed-by: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/zcache/debug.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/zcache/debug.c b/drivers/staging/zcache/debug.c
> index 254dada..d2d1fdf 100644
> --- a/drivers/staging/zcache/debug.c
> +++ b/drivers/staging/zcache/debug.c
> @@ -31,8 +31,8 @@ static struct debug_entry {
> ATTR(eph_nonactive_puts_ignored),
> ATTR(pers_nonactive_puts_ignored),
> #ifdef CONFIG_ZCACHE_WRITEBACK
> - ATTR(zcache_outstanding_writeback_pages),
> - ATTR(zcache_writtenback_pages),
> + ATTR(outstanding_writeback_pages),
> + ATTR(writtenback_pages),
> #endif
> };
> #undef ATTR
> --
> 1.7.7.6
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>