On Mon 01-04-13 10:39:00, Li Zefan wrote: > This might cause use-after-free bug. > > Signed-off-by: Li Zefan <lizefan@xxxxxxxxxx> Acked-by: Michal Hocko <mhocko@xxxxxxx> > --- > > found when reading the code. > > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 8ec501c..6391046 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3186,12 +3186,12 @@ void memcg_release_cache(struct kmem_cache *s) > > root = s->memcg_params->root_cache; > root->memcg_params->memcg_caches[id] = NULL; > - mem_cgroup_put(memcg); > > mutex_lock(&memcg->slab_caches_mutex); > list_del(&s->memcg_params->list); > mutex_unlock(&memcg->slab_caches_mutex); > > + mem_cgroup_put(memcg); > out: > kfree(s->memcg_params); > } > -- > 1.8.0.2 -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>