> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> >> index 97454b3..9b1b494 100644
> >> --- a/mm/memory_hotplug.c
> >> +++ b/mm/memory_hotplug.c
> >> @@ -751,10 +751,6 @@ EXPORT_SYMBOL_GPL(restore_online_page_callback);
> >>
> >> void __online_page_set_limits(struct page *page)
> >> {
> >> - unsigned long pfn = page_to_pfn(page);
> >> -
> >> - if (pfn >= num_physpages)
> >> - num_physpages = pfn + 1;
> >> }
> >> EXPORT_SYMBOL_GPL(__online_page_set_limits);
> >
> > How can this be correct?
> > With this change __online_page_set_limits() is now a nop.
> Hi Sam,
> We will eventually remove the global variable num_physpages in the last patch.
> I kept the nop __online_page_set_limits() because I have a plan to use it to fix other
> bugs in memory hotplug, otherwise it may be killed too.
The xen ballon driver uses __online_page_set_limits for memory
hotplug - so this will break this driver afaics.
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>