Dave Hansen wrote:
> On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote:
> > From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
> >
> > For now we still write/read at most PAGE_CACHE_SIZE bytes a time.
> >
> > This implementation doesn't cover address spaces with backing store.
> ...
> > --- a/mm/filemap.c
> > +++ b/mm/filemap.c
> > @@ -1165,12 +1165,23 @@ find_page:
> > if (unlikely(page == NULL))
> > goto no_cached_page;
> > }
> > + if (PageTransTail(page)) {
> > + page_cache_release(page);
> > + page = find_get_page(mapping,
> > + index & ~HPAGE_CACHE_INDEX_MASK);
> > + if (!PageTransHuge(page)) {
> > + page_cache_release(page);
> > + goto find_page;
> > + }
> > + }
>
> So, we're going to do a read of a file, and we pulled a tail page out of
> the page cache. Why can't we just deal with the tail page directly?
Good point. I'll redo it once again.
First I thought to make it possible to read/write more PAGE_SIZE at once.
If not take this option in account for now, it's possible to make code much
cleaner.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>