On 03/28/2013 05:09 AM, Andrew Morton wrote: > On Wed, 6 Mar 2013 16:51:20 +0800 Bob Liu <lliubbo@xxxxxxxxx> wrote: > >> With the goal of allowing tmem backends (zcache, ramster, Xen tmem) to be >> built/loaded as modules rather than built-in and enabled by a boot parameter, >> this patch provides "lazy initialization", allowing backends to register to >> frontswap even after swapon was run. Before a backend registers all calls >> to init are recorded and the creation of tmem_pools delayed until a backend >> registers or until a frontswap store is attempted. > > Your version of this patch series differed from Konrad's "[PATCH v3] > Make frontswap+cleancache and its friend be modularized." significantly. > > In particular, Konrad had four additional patches: > > Subject: frontswap: remove the check for frontswap_enabled > Subject: frontswap: Use static_key instead of frontswap_enabled and frontswap_ops > Subject: cleancache: Remove the check for cleancache_enabled. > Subject: cleancache: Use static_key instead of cleancache_ops and cleancache_enabled. > > How come? > These four patches will cause compile error when CONFIG_FRONTSWAP/CLEANCACHE not defined. So i replaced them with: [PATCH V2 03/11] mm: frontswap: cleanup code [PATCH V2 07/11] mm: cleancache: clean up cleancache_enabled to fix the compile error and cleanup the code. That's all the changes V1-->V2. Sorry for not send out [patch v2 0/11] to describe the change log before you merge them. -- Regards, -Bob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>