On 03/15/2013 06:22 AM, Kirill A. Shutemov wrote: > Hillf Danton wrote: >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov >> <kirill.shutemov@xxxxxxxxxxxxxxx> wrote: >>> >>> There's only one caller of do_generic_file_read() and the only actor is >>> file_read_actor(). No reason to have a callback parameter. >>> >> This cleanup is not urgent if it nukes no barrier for THP cache. > > Yes, it's not urgent. On other hand it can be applied upstream right now ;) If someone might pick this up and merge it right away, it's probably best to put it very first in the series and call it out as such to the person you expect to pick it up, or even send it up to them separately. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>