When implementing movablemem_map boot option, we introduced an array movablemem_map.map[] to store the memory ranges to be set as ZONE_MOVABLE. Since ZONE_MOVABLE is the latst zone of a node, if user didn't specify the whole node memory range, we need to extend it to the node end so that we can use it to prevent memblock from allocating memory in the ranges user didn't specify. We now implement movablemem_map boot option like this: /* * For movablemem_map=nn[KMG]@ss[KMG]: * * SRAT: |_____| |_____| |_________| |_________| ...... * node id: 0 1 1 2 * user specified: |__| |___| * movablemem_map: |___| |_________| |______| ...... * * Using movablemem_map, we can prevent memblock from allocating memory * on ZONE_MOVABLE at boot time. * * NOTE: In this case, SRAT info will be ingored. */ Signed-off-by: Tang Chen <tangchen@xxxxxxxxxxxxxx> --- arch/x86/mm/srat.c | 34 ++++++++++++++++++++++++++++++---- 1 files changed, 30 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c index 6cd4d33..44a9b9b 100644 --- a/arch/x86/mm/srat.c +++ b/arch/x86/mm/srat.c @@ -150,16 +150,42 @@ static void __init sanitize_movablemem_map(int nid, u64 start, u64 end) start_pfn = PFN_DOWN(start); end_pfn = PFN_UP(end); + /* + * For movablemem_map=nn[KMG]@ss[KMG]: + * + * SRAT: |_____| |_____| |_________| |_________| ...... + * node id: 0 1 1 2 + * user specified: |__| |___| + * movablemem_map: |___| |_________| |______| ...... + * + * Using movablemem_map, we can prevent memblock from allocating memory + * on ZONE_MOVABLE at boot time. + */ overlap = movablemem_map_overlap(start_pfn, end_pfn); if (overlap >= 0) { + /* + * If this range overlaps with movablemem_map, then update + * zone_movable_limit[nid] if it has lower start pfn. + */ start_pfn = max(start_pfn, movablemem_map.map[overlap].start_pfn); - if (zone_movable_limit[nid]) - zone_movable_limit[nid] = min(zone_movable_limit[nid], - start_pfn); - else + if (!zone_movable_limit[nid] || + zone_movable_limit[nid] > start_pfn) zone_movable_limit[nid] = start_pfn; + + /* Insert the higher part of the overlapped range. */ + if (movablemem_map.map[overlap].end_pfn < end_pfn) + insert_movablemem_map(start_pfn, end_pfn); + } else { + /* + * If this is a range higher than zone_movable_limit[nid], + * insert it to movablemem_map because all ranges higher than + * zone_movable_limit[nid] on this node will be ZONE_MOVABLE. + */ + if (zone_movable_limit[nid] && + start_pfn > zone_movable_limit[nid]) + insert_movablemem_map(start_pfn, end_pfn); } } #else /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */ -- 1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>