On Mon, Mar 18, 2013 at 03:02:10PM +0800, Hillf Danton wrote: > On Sun, Mar 17, 2013 at 9:04 PM, Mel Gorman <mgorman@xxxxxxx> wrote: > > > > + /* If no reclaim progress then increase scanning priority */ > > + if (sc.nr_reclaimed - nr_reclaimed == 0) > > + raise_priority = true; > > > > /* > > - * Fragmentation may mean that the system cannot be > > - * rebalanced for high-order allocations in all zones. > > - * At this point, if nr_reclaimed < SWAP_CLUSTER_MAX, > > - * it means the zones have been fully scanned and are still > > - * not balanced. For high-order allocations, there is > > - * little point trying all over again as kswapd may > > - * infinite loop. > > - * > > - * Instead, recheck all watermarks at order-0 as they > > - * are the most important. If watermarks are ok, kswapd will go > > - * back to sleep. High-order users can still perform direct > > - * reclaim if they wish. > > + * Raise priority if scanning rate is too low or there was no > > + * progress in reclaiming pages > 2) this comment is already included also in the above one? > > > */ > > - if (sc.nr_reclaimed < SWAP_CLUSTER_MAX) > > - order = sc.order = 0; > > - > > - goto loop_again; > > - } > > + if (raise_priority || sc.nr_reclaimed - nr_reclaimed == 0) > 1) duplicated reclaim check with the above one, merge error? > Yes, thanks. Duplicated check removed now. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>