On Mon, Mar 18, 2013 at 10:53:04PM -0700, Yinghai Lu wrote: > On Mon, Mar 18, 2013 at 10:16 PM, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> wrote: > > Currently, we do memset() before reserving the area. > > This may not cause any problem, but it is somewhat weird. > > So change execution order. > > > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > > > diff --git a/mm/nobootmem.c b/mm/nobootmem.c > > index 589c673..f11ec1c 100644 > > --- a/mm/nobootmem.c > > +++ b/mm/nobootmem.c > > @@ -46,8 +46,8 @@ static void * __init __alloc_memory_core_early(int nid, u64 size, u64 align, > > return NULL; > > > > ptr = phys_to_virt(addr); > > - memset(ptr, 0, size); > > memblock_reserve(addr, size); > > + memset(ptr, 0, size); > > move down ptr = ... too ? Okay. I will send v2 soon. > > > /* > > * The min_count is set to 0 so that bootmem allocated blocks > > * are never reported as leaks. > > -- > > 1.7.9.5 > > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>