On Fri, 15 Mar 2013 17:02:41 +0100 Michal Hocko <mhocko@xxxxxxx> wrote: > On Thu 14-03-13 18:51:03, Gerald Schaefer wrote: > > Commit abf09bed3c "s390/mm: implement software dirty bits" > > introduced another difference in the pte layout vs. the pmd layout > > on s390, thoroughly breaking the s390 support for hugetlbfs. This > > requires replacing some more pte_xxx functions in mm/hugetlbfs.c > > with a huge_pte_xxx version. > > > > This patch introduces those huge_pte_xxx functions and their > > generic implementation in asm-generic/hugetlb.h, which will now be > > included on all architectures supporting hugetlbfs apart from s390. > > This change will be a no-op for those architectures. > > > > Signed-off-by: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx> > > yes this looks much better. I cannot talk about s390 part because I am > not familiar with it but the rest looks good to me. > > Maybe one nit, though. pte_page and pte_same do not have their > huge_Foo counterparts. Yes, a few pte_xxx calls remain. I left those because they still work on s390 (and all other archs apparently). I am thinking about a more complete cleanup, maybe eliminating the ambiguous use of pte_t for hugetlb completely. Not sure if I can get to it before Martin introduces the next s390 pte changes :) Thanks, Gerald -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>