On Thu, Mar 14, 2013 at 09:58:31PM +0100, Toralf Förster wrote: > On 03/14/2013 09:51 PM, richard -rw- weinberger wrote: > > Can you please re-run with the attached patch. > > I'm wondering how much memory is requested. > >>From reading the source I'd say it must be less than PAGE_SIZE. > > But such a small allocation would not trigger the WARN_ON()... > > > 2013-03-14T21:56:58.000+01:00 trinity sshd[1158]: pam_unix(sshd:session): session opened for user tfoerste by (uid=0) > 2013-03-14T21:56:59.852+01:00 trinity kernel: memdup_user: -14 > 2013-03-14T21:56:59.852+01:00 trinity kernel: ------------[ cut here ]------------ > 2013-03-14T21:56:59.852+01:00 trinity kernel: WARNING: at mm/page_alloc.c:2386 __alloc_pages_nodemask+0x153/0x750() > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd14: [<08342dd8>] dump_stack+0x22/0x24 > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd2c: [<0807d0da>] warn_slowpath_common+0x5a/0x80 > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd54: [<0807d1a3>] warn_slowpath_null+0x23/0x30 > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd64: [<080d3213>] __alloc_pages_nodemask+0x153/0x750 > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbdf0: [<080d3838>] __get_free_pages+0x28/0x50 > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbe08: [<080fc48f>] __kmalloc_track_caller+0x3f/0x180 > 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbe30: [<080dec82>] memdup_user+0x32/0x70 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbe4c: [<080dee7e>] strndup_user+0x3e/0x60 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbe68: [<0811b440>] copy_mount_string+0x30/0x50 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbe7c: [<0811be0a>] sys_mount+0x1a/0xe0 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbeac: [<08062a92>] handle_syscall+0x82/0xb0 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbef4: [<08074e7d>] userspace+0x46d/0x590 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbfec: [<0805f7cc>] fork_handler+0x6c/0x70 > 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbffc: [<5a5a5a5a>] 0x5a5a5a5a > 2013-03-14T21:56:59.853+01:00 trinity kernel: > 2013-03-14T21:56:59.853+01:00 trinity kernel: ---[ end trace 5bf182a223bd623c ]--- > 2013-03-14T21:56:59.853+01:00 trinity kernel: memdup_user: -14 hah, strndup_user taking a signed long instead of a size_t as it's length arg. either it needs to change, or it needs an explicit check for < 1 I wonder how many other paths make it possible to pass negative numbers here. Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>