On Tue, Mar 12, 2013 at 02:42:15PM -0700, Andrew Morton wrote:
> On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu <liuj97@xxxxxxxxx> wrote:
>
> > Use helper function free_highmem_page() to free highmem pages into
> > the buddy system.
> >
> > ...
> >
> > --- a/arch/sparc/mm/init_32.c
> > +++ b/arch/sparc/mm/init_32.c
> > @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn)
> > printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn);
> > #endif
> >
> > - for (tmp = start_pfn; tmp < end_pfn; tmp++) {
> > - struct page *page = pfn_to_page(tmp);
> > -
> > - ClearPageReserved(page);
> > - init_page_count(page);
> > - __free_page(page);
> > - totalhigh_pages++;
> > - }
> > + for (tmp = start_pfn; tmp < end_pfn; tmp++)
> > + free_higmem_page(pfn_to_page(tmp));
> > }
>
> This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK
> because CONFIG_HIGHMEM=n isn't possible on sparc32.
Correct - from arch/sparc/Kconfig
config HIGHMEM
bool
default y if SPARC32
> This patch and one other mistyped "free_highmem_page". I got lazy and
> edited those patches in-place.
Good spot!
You can add my:
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>