Paul Mackerras <paulus@xxxxxxxxx> writes: > On Tue, Feb 26, 2013 at 01:34:57PM +0530, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> >> >> We will use this later with THP changes to request for pmd table of double the size. >> THP code does PTE page allocation along with large page request and deposit them >> for later use. This is to ensure that we won't have any failures when we split >> huge pages to regular pages. >> >> On powerpc we want to use the deposited PTE page for storing hash pte slot and >> secondary bit information for the HPTEs. Hence we save them in the second half >> of the pmd table. > > Looks OK, but you should explain why you made the wholesale change of > "shift" to "index". Is there some important semantic difference, or > do you just prefer the "index" name for some reason? > Now with table_size argument, the first arg is no more the shift value, rather it is index into the array. Hence i changed the variable name. I will split that patch to make it easy for review. -aneesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>