Re: [PATCH 1/2] mm: fadvise: fix POSIX_FADV_DONTNEED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/26/2013 9:06 AM, Andrea Righi wrote:
> I also like this approach, it looks very similar to the one that I 
> proposed a long time ago. However, last time we ended up saying
> that the next step should have been a proposal for a better page
> cache management interface for the userland, adding more fadvise()
> flags, obviously without breaking the current behavior.

If someone wants to add more flags, good for them, but how about we
get the ones we have right first? ;)

> We started with these ideal requirements, but unfortunately I
> didn't go ahead with this project: 
> http://marc.info/?l=linux-kernel&m=130917619416123&w=2
> 
> About breaking the compatibility, keep in mind that even tools like
> dd, for example, has been modified to support invalidating the
> cache for a file via POSIX_FADV_DONTNEED: 
> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commit;h=5f311553

I
> 
don't see how dd would be harmed by this change.

> And it expects to discard cache for the target pages, when
> possible, even if POSIX just says that it will not access the pages
> again any time soon.

Other than the description for the human user, I don't see how it
actually has this expectation.

In fact, when under high cache pressure, the description would still
be essentially correct since the pages will be discarded, just not
necessarily by the time the syscall returns.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRLNc8AAoJEJrBOlT6nu75yHIIAMQzRiTW0jgTTU+sICmWtMjE
klHGX0NtnXMirs9imkOUkSRhpCpS02dxrZUEm0GfMSbKBgYIQXUOChTzY9jBCghj
A4vJ697NS2UaLETtx1FXGRoaPvDD3VWYDL5gtzE4W05tnmim2QdjBGqfBPcHr9nL
RO586QUpiq66Fv15QdzIevMXrWEvBuyJKRQA/Hln2Sirmy8vZiEpa0O+qew35217
W7NgPsc37b/uGK2sEJsxP6tO6wnf7absk1laZJrCsHkNNGjGLYKBfY2ASs7OMsAB
xDXNap0eyFoWChSlMkbLaaBNdAHN/9EqkkeoN/WyiGA/ePYqAxISrb8EnSDVD1E=
=aFFY
-----END PGP SIGNATURE-----

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]