On Wed, 20 Feb 2013 12:26:26 -0800 (PST) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > @@ -2463,19 +2464,23 @@ static int shmem_parse_options(char *options, struct shmem_sb_info *sbinfo, > > if (!gid_valid(sbinfo->gid)) > > goto bad_val; > > } else if (!strcmp(this_char,"mpol")) { > > - if (mpol_parse_str(value, &sbinfo->mpol)) > > + mpol_put(mpol); > > I haven't tested to check, but don't we need > mpol = NULL; > here, in case the new option turns out to be bad? We do. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>