On Fri, Feb 01, 2013 at 02:02:18PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 28, 2013 at 10:00:08AM +0900, Minchan Kim wrote:
> > @@ -663,7 +661,7 @@ static inline void __zs_unmap_object(struct mapping_area *area,
> >
> > flush_cache_vunmap(addr, end);
> > unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
> > - local_flush_tlb_kernel_range(addr, end);
> > + flush_tlb_kernel_range(addr, end);
>
> void unmap_kernel_range_noflush(unsigned long addr, unsigned long size)
> {
> vunmap_page_range(addr, addr + size);
> }
>
> void unmap_kernel_range(unsigned long addr, unsigned long size)
> {
> unsigned long end = addr + size;
>
> flush_cache_vunmap(addr, end);
> vunmap_page_range(addr, end);
> flush_tlb_kernel_range(addr, end);
> }
>
> So, given the above, what would be different between:
>
> unsigned long end = addr + (PAGE_SIZE * 2);
>
> flush_cache_vunmap(addr, end);
> unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
> flush_tlb_kernel_range(addr, end);
>
> (which is what it becomes after your change) and
>
> unmap_kernel_range(addr, PAGE_SIZE * 2);
>
> ?
Good point. I will clean it up.
Thanks.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>