On Tue 29-01-13 23:51:42, Jeff Liu wrote: > On 01/29/2013 10:56 PM, Michal Hocko wrote: > > On Mon 28-01-13 18:54:47, Jeff Liu wrote: > >> Introduce swap_cgroup_init()/swap_cgroup_free() to allocate buffers when creating the first > >> non-root memcg and deallocate buffers on the last non-root memcg is gone. > > > > I think this deserves more words ;) At least it would be good to > > describe contexts from which init and free might be called. What are the > > locking rules. > > Also swap_cgroup_destroy sounds more in pair with swap_cgroup_init. > Will improve the comments log as well as fix the naming. Btw, I named > it as swap_cgroup_free() because we have mem_cgroup_free() corresponding > to mem_cgroup_init(). :) I do see mem_cgroup_alloc and __mem_cgroup_free. Anyway this is not that important. Consistent naming is not any rule. It is nice to have though. So take these renaming suggestions as hints rather than you definitely _have_ to do that. [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>