On Fri, 25 Jan 2013 18:01:59 -0800 (PST) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > +static int remove_all_stable_nodes(void) > +{ > + struct stable_node *stable_node; > + int nid; > + int err = 0; > + > + for (nid = 0; nid < nr_node_ids; nid++) { > + while (root_stable_tree[nid].rb_node) { > + stable_node = rb_entry(root_stable_tree[nid].rb_node, > + struct stable_node, node); > + if (remove_stable_node(stable_node)) { > + err = -EBUSY; It's a bit rude to overwrite remove_stable_node()'s return value. > + break; /* proceed to next nid */ > + } > + cond_resched(); Why is this here? > + } > + } > + return err; > +} -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>