On Fri, Jan 25, 2013 at 10:45:04AM -0600, Seth Jennings wrote: > On 01/07/2013 02:41 PM, Seth Jennings wrote: > > On 01/07/2013 02:32 PM, Greg Kroah-Hartman wrote: > >> On Mon, Jan 07, 2013 at 02:24:36PM -0600, Seth Jennings wrote: > >>> debugfs currently lack the ability to create attributes > >>> that set/get atomic_t values. > >> > >> I hate to ask, but why would you ever want to do such a thing? > > > > There are a few atomic_t statistics in zswap that are valuable to have > > in the debugfs attributes. Rather than have non-atomic mirrors of all > > of them, as is done in zcache right now (see > > drivers/staging/ramster/zcache-main.c:131), I thought this to be a > > cleaner solution. > > > > Granted, I personally have no use for the setting part; only the > > getting part. I only included the setting operations to keep the > > balance and conform with the rest of the debugfs implementation. > > Greg, I never did get your ack or rejection here. Are you ok with > this patch? Some patches you just hold your breath and hope the sender goes away and never asks about again, this was one of them :) Seriously, it's fine, feel free to take it through whatever tree it depends on. Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>