It's quite obvious that the return statement after BUG() is invalid, we had better move BUG() to the default choice of the switch. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> --- kernel/res_counter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/res_counter.c b/kernel/res_counter.c index ff55247..748a3bc 100644 --- a/kernel/res_counter.c +++ b/kernel/res_counter.c @@ -135,10 +135,9 @@ res_counter_member(struct res_counter *counter, int member) return &counter->failcnt; case RES_SOFT_LIMIT: return &counter->soft_limit; + default: + BUG(); }; - - BUG(); - return NULL; } ssize_t res_counter_read(struct res_counter *counter, int member, -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>