On Mon 21-01-13 15:13:33, Glauber Costa wrote: > When use_hierarchy is enabled, we acquire an extra reference count > in our parent during cgroup creation. We don't release it, though, > if any failure exist in the creation process. > > Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx> > Reported-by: Michal Hocko <mhocko@suse> If you put this one to the head of the series we can backport it to stable which is preferred, although nobody have seen this as a problem. > --- > mm/memcontrol.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 5a247de..3949123 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6167,6 +6167,8 @@ mem_cgroup_css_online(struct cgroup *cont) > * call __mem_cgroup_free, so return directly > */ > mem_cgroup_put(memcg); > + if (parent->use_hierarchy) > + mem_cgroup_put(parent); > } > return error; > } > -- > 1.8.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>