----- Original Message ----- > From: "Kamezawa Hiroyuki" <kamezawa.hiroyu@xxxxxxxxxxxxxx> > To: "Tejun Heo" <tj@xxxxxxxxxx> > Cc: "David Rientjes" <rientjes@xxxxxxxxxx>, "Michal Hocko" <mhocko@xxxxxxx>, "Zhouping Liu" <zliu@xxxxxxxxxx>, > linux-mm@xxxxxxxxx, "Li Zefan" <lizefan@xxxxxxxxxx>, "CAI Qian" <caiqian@xxxxxxxxxx>, "LKML" > <linux-kernel@xxxxxxxxxxxxxxx>, "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx> > Sent: Saturday, June 30, 2012 11:45:41 AM > Subject: Re: memcg: cat: memory.memsw.* : Operation not supported > > (2012/06/29 3:31), Tejun Heo wrote: > > Hello, KAME. > > > > On Thu, Jun 28, 2012 at 01:04:16PM +0900, Kamezawa Hiroyuki wrote: > >>> I still wish it's folded into CONFIG_MEMCG and conditionalized > >>> just on > >>> CONFIG_SWAP tho. > >>> > >> > >> In old days, memsw controller was not very stable. So, we devided > >> the config. > >> And, it makes size of memory for swap-device double (adds 2bytes > >> per swapent.) > >> That is the problem. > > > > I see. Do you think it's now reasonable to drop the separate > > config > > option? Having memcg enabled but swap unaccounted sounds > > half-broken > > to me. > > > > Hmm. Maybe it's ok if we can keep boot option. I'll cook a patch in > the next week. Hello Kame and All, Sorry for so delay to open the thread. (please open the link https://lkml.org/lkml/2012/6/26/547 if you don't remember the topic) do you have any updates for the issue? I checked the latest version, if we don't open CONFIG_MEMCG_SWAP_ENABLED(commit c255a458055e changed CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED as CONFIG_MEMCG_SWAP_ENABLED), the issue still exist: [root@dhcp-8-128 ~] cat .config | grep -i memcg CONFIG_MEMCG=y CONFIG_MEMCG_SWAP=y # CONFIG_MEMCG_SWAP_ENABLED is not set CONFIG_MEMCG_KMEM=y [root@dhcp-8-128 ~] uname -r 3.8.0-rc4+ [root@dhcp-8-128 ~] cat memory.memsw.* cat: memory.memsw.failcnt: Operation not supported cat: memory.memsw.limit_in_bytes: Operation not supported cat: memory.memsw.max_usage_in_bytes: Operation not supported cat: memory.memsw.usage_in_bytes: Operation not supported As David said, we should not export memory.memsw.* files if we disable CONFIG_MEMCG_SWAP_ENABLED, or return -EINVAL, right? (please correct me if I'm wrong) -- Thanks, Zhouping -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>