On 01/18/2013 07:25 PM, Michal Hocko wrote: >> - spin_lock_init(&memcg->move_lock); >> > + memcg->swappiness = mem_cgroup_swappiness(parent); > Please move this up to oom_kill_disable and use_hierarchy > initialization. One thing: wouldn't moving it to inside use_hierarchy be a change of behavior here? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>