On Thu, 2013-01-17 at 13:36 -0800, Eric Dumazet wrote:
> > Index: linux/mm/slub.c
> > ===================================================================
> > --- linux.orig/mm/slub.c 2013-01-15 10:42:08.490183607 -0600
> > +++ linux/mm/slub.c 2013-01-17 15:27:48.973051155 -0600
> > @@ -1993,8 +1993,8 @@ static inline void flush_slab(struct kme
> > deactivate_slab(s, c->page, c->freelist);
> >
> > c->tid = next_tid(c->tid);
> > - c->page = NULL;
> > c->freelist = NULL;
> > + c->page = NULL;
> > }
> >
> > /*
> > @@ -2227,8 +2227,8 @@ redo:
> > if (unlikely(!node_match(page, node))) {
> > stat(s, ALLOC_NODE_MISMATCH);
> > deactivate_slab(s, page, c->freelist);
> > - c->page = NULL;
> > c->freelist = NULL;
> > + c->page = NULL;
> > goto new_slab;
> > }
> >
> > @@ -2239,8 +2239,8 @@ redo:
> > */
> > if (unlikely(!pfmemalloc_match(page, gfpflags))) {
> > deactivate_slab(s, page, c->freelist);
> > - c->page = NULL;
> > c->freelist = NULL;
> > + c->page = NULL;
> > goto new_slab;
> > }
> >
>
> Without appropriate barriers, this change is a shoot in the dark.
Totally agree.
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>