Hi Michal, On 01/15/2013 10:20 PM, Michal Hocko wrote: >> +#else >> > +void register_page_bootmem_info_node(struct pglist_data *pgdat) >> > +{ >> > + /* TODO */ >> > +} > I think that TODO is misleading here because the function should be > empty if !CONFIG_HAVE_BOOTMEM_INFO_NODE. I would also suggest updating Yes, I got lost here, you are right, thanks. > include/linux/memory_hotplug.h and removing the arch specific functions > without any implementation. Something like (untested) patch below: I will merge your suggestion in next version. thanks, linfeng > --- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>